Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFC] Avoid some crashes at SIGINT
Date: Wed, 27 Feb 2008 20:23:00 -0000	[thread overview]
Message-ID: <20080227200848.GA3701@adacore.com> (raw)
In-Reply-To: <20080227025444.GA22935@caradoc.them.org>

> The new interface is gdb_call_async_signal_handler.  SIGINT handlers,
> when running in non-async mode or otherwise wanting an "immediate"
> reaction, can call this and pass it the async handler's token instead
> of duplicating the async handler's code.  Then for POSIX platforms
> the function is called immediately and for Windows it is deferred
> to gdb_select.  The event loop always uses gdb_select and so do
> the remote targets which had SIGINT handlers.

This is pretty clever. I also looked at the patch, and it looked
sensible to me. But I admit that I'm not completely familiar with
this part of the code.

> Some day, we may want to use the same mechanism that I've added here
> for POSIX platforms too.  That will close the race conditions of where
> we are when the signal arrives.  That requires async GDB; Vladimir has
> been looking at Nick's and Apple's patches for this again.  For now,
> I left the POSIX platform behavior unchanged.

I look forward to this.


-- 
Joel


  reply	other threads:[~2008-02-27 20:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-27  3:41 Daniel Jacobowitz
2008-02-27 20:23 ` Joel Brobecker [this message]
2008-03-05 17:24 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080227200848.GA3701@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox