From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21741 invoked by alias); 27 Feb 2008 03:43:24 -0000 Received: (qmail 21728 invoked by uid 22791); 27 Feb 2008 03:43:23 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 27 Feb 2008 03:43:02 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id m1R3gxFY394440 for ; Wed, 27 Feb 2008 03:42:59 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m1R3gxoU2277414 for ; Wed, 27 Feb 2008 04:42:59 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m1R3gxJG031861 for ; Wed, 27 Feb 2008 03:42:59 GMT Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m1R3gx1j031858; Wed, 27 Feb 2008 03:42:59 GMT Message-Id: <200802270342.m1R3gx1j031858@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 27 Feb 2008 04:42:59 +0100 Subject: Re: [rfc][2/3] gdbserver bi-arch support: core s390x part To: drow@false.org (Daniel Jacobowitz) Date: Wed, 27 Feb 2008 03:44:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20080226035527.GE4456@caradoc.them.org> from "Daniel Jacobowitz" at Feb 25, 2008 10:55:27 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00426.txt.bz2 Daniel Jacobowitz wrote: > You're welcome to prod me when I drop out in the middle of a > conversation like this. Really. I'm sorry about the delay. Hey, it's no problem ... I've been busy myself; I would have gotten around to pinging you sooner or later ;-) > On Wed, Jan 30, 2008 at 12:33:33AM +0100, Ulrich Weigand wrote: > > Yes. Note that there are two different issues: whether we need > > to clear the high bit depends on the architecture of gdbserver, > > but the size of the register depends on the architecture of > > the inferior. To simplify the latter issue, maybe it would be > > nice if generic code had a "collect_register_as_addr" helper > > that would check the register's size and convert its contents > > to CORE_ADDR as appropriate? > > Then we'd have room to squabble about whether that function sign > extended or not. Let's hold off on this one. Ah, right. Fine with me. > > * configure.srv [s390x-*-linux*]: Set srv_regobj to include both > > reg-s390.o and reg-s390x.o. > > > > * linux-low.c (new_inferior): New global variable. > > (linux_create_inferior, linux_attach): Set it. > > (linux_wait_for_process): Call the_low_target.arch_setup after the > > target has stopped for the first time. > > (initialize_low): Do not call the_low_target.arch_setup. > > > > * linux-s390-low.c (s390_get_pc): Support bi-arch operation. > > (s390_set_pc): Likewise. > > (s390_arch_setup): New function. > > (the_low_target): Use s390_arch_setup as arch_setup routine. > > > > * regcache.c (realloc_register_cache): New function. > > (set_register_cache): Call it for each existing regcache. > > This looks great to me. Thanks, I've checked this in now. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com