From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30429 invoked by alias); 26 Feb 2008 22:37:07 -0000 Received: (qmail 30415 invoked by uid 22791); 26 Feb 2008 22:37:06 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 26 Feb 2008 22:36:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 70A0C2AA68D; Tue, 26 Feb 2008 17:36:47 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id GZF2oZJgIu0P; Tue, 26 Feb 2008 17:36:47 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 369E02AA677; Tue, 26 Feb 2008 17:36:47 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 2B23DE7ACB; Tue, 26 Feb 2008 14:36:45 -0800 (PST) Date: Tue, 26 Feb 2008 22:55:00 -0000 From: Joel Brobecker To: Vladimir Prus Cc: Nick Roberts , gdb-patches@sourceware.org Subject: Re: (gdb-6.8) Discard breakpoint address if shared library is unloaded Message-ID: <20080226223645.GC5326@adacore.com> References: <20080204214226.GF20922@adacore.com> <200802251204.41848.vladimir@codesourcery.com> <20080225192941.GA20216@adacore.com> <200802261114.35727.vladimir@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200802261114.35727.vladimir@codesourcery.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00414.txt.bz2 > > Pfew, some of these lines were so long that it was really tough to > > review some of them, but after stretching my terminal to some 300 > > characters wide, it became much easier :-). > > Uhm, you mean those annota* tests? Those are scary indeed; I really wish > the annotations somehow disappear tomorrow. I wasn't really thinking about the annotations themselves, but rather about the test where the expected output is one giant string 300-400 characters long, and the changes are 2 spaces that have been removed. Verifying what has changed inside those lines was tricky... Maybe using gdb_expect_list would improve the situation. But that's for another rainy day... -- Joel