From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-54239-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2623 invoked by alias); 26 Feb 2008 08:15:18 -0000
Received: (qmail 2613 invoked by uid 22791); 26 Feb 2008 08:15:17 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 26 Feb 2008 08:14:49 +0000
Received: (qmail 16050 invoked from network); 26 Feb 2008 08:14:42 -0000
Received: from unknown (HELO localhost) (vladimir@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 26 Feb 2008 08:14:42 -0000
From: Vladimir Prus <vladimir@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Subject: Re: (gdb-6.8) Discard breakpoint address if shared library is unloaded
Date: Tue, 26 Feb 2008 10:03:00 -0000
User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405)
Cc: Nick Roberts <nickrob@snap.net.nz>,  gdb-patches@sourceware.org
References: <20080204214226.GF20922@adacore.com> <200802251204.41848.vladimir@codesourcery.com> <20080225192941.GA20216@adacore.com>
In-Reply-To: <20080225192941.GA20216@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain;   charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200802261114.35727.vladimir@codesourcery.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-02/txt/msg00385.txt.bz2

On Monday 25 February 2008 22:29:41 Joel Brobecker wrote:
> Hi Volodya,
> 
> >     [gdb]
> >     2008-02-15  Nick Roberts  <nickrob@snap.net.nz>
> > 
> >             * breakpoint.c (print_one_breakpoint_location): Revert Enb field
> >             to old format.  Discard breakpoint address if shared library is
> >             unloaded.
> >             (breakpoint_1): Adjust formatting of table header accordingly.
> > 
> >     [gdb/testsuite]
> >     2008-02-25  Vladimir Prus  <vladimir@codesourcery.com>
> > 
> >         * gdb.base/annota1.exp: Adjust for 'info break'
> >         format changes.
> >         * gdb.base/annota3.exp: Likewise.
> >         * gdb.base/break.exp: Likewise.
> >         * gdb.base/condbreak.exp: Likewise.
> >         * gdb.base/pending.exp: Likewise.
> >         * gdb.base/sepdebug.exp: Likewise.
> >         * gdb.base/unload.exp: Likewise.
> >         * gdb.cp/ovldbreak.exp: Likewise.
> >         * gdb.mi/mi-pending.exp: Likewise.
> 
> Pfew, some of these lines were so long that it was really tough to
> review some of them, but after stretching my terminal to some 300
> characters wide, it became much easier :-).

Uhm, you mean those annota* tests? Those are scary indeed; I really wish
the annotations somehow disappear tomorrow.

> Patch is approved. Many thanks to Nick and Vladimir for getting
> this done.

Checked in.

- Volodya