From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4486 invoked by alias); 26 Feb 2008 01:21:03 -0000 Received: (qmail 4472 invoked by uid 22791); 26 Feb 2008 01:21:02 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 26 Feb 2008 01:20:39 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 4C99898118; Tue, 26 Feb 2008 01:20:38 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 2869A9801D; Tue, 26 Feb 2008 01:20:38 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JToUn-0001Ej-BH; Mon, 25 Feb 2008 20:20:37 -0500 Date: Tue, 26 Feb 2008 02:24:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: rob.quill@gmail.com, gdb-patches@sourceware.org Subject: Re: Remove deprecated_set_value_type (part 1) Message-ID: <20080226012037.GA4456@caradoc.them.org> Mail-Followup-To: Mark Kettenis , rob.quill@gmail.com, gdb-patches@sourceware.org References: <20080129195506.GE9019@caradoc.them.org> <200801301804.m0UI4eWR018093@brahms.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200801301804.m0UI4eWR018093@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00379.txt.bz2 On Wed, Jan 30, 2008 at 07:04:40PM +0100, Mark Kettenis wrote: > There are some code style problems here too, and although they're not > your fault, it'd be nice to fix them while you're there. Actually, it > looks to me as if the temparg variable is completely redundant now, so > the above could be simplified to > > val = value_addr (val); Mark's right; also, there are still formatting problems with the patch that I commented on the last time I reviewed it :-( Rob, let me know if you'd like me to point them out individually. -- Daniel Jacobowitz CodeSourcery