On Wednesday 20 February 2008 23:25:50 Vladimir Prus wrote:
> On Wednesday 20 February 2008 22:20:51 Nick Roberts wrote:
> >  > So how about you submit a complete patch, following the usual protocol
> >  > rather than an abbreviated one? I'll review it promptly, and we can
> >  > put this episode behind us. As I said before, I reviewed the breakpoint.c
> >  > patch and it looked fine, so it's just a matter of taking a look at
> >  > the testsuite failures and adjust the testsuite accordingly (if
> >  > justified).
> > 
> > Some or all of the other failures occur in these files:
> > 
> > 2007-09-23  Vladimir Prus  <vladimir@codesourcery.com>
> > 	
> > 	* gdb.base/annota1.exp: Adjust for 'info break'
> > 	format changes.
> > 	* gdb.base/annota3.exp: Likewise.
> > 	* gdb.base/break.exp: Likewise.
> > 	* gdb.base/condbreak.exp: Likewise.
> > 	* gdb.base/pending.exp: Likewise.
> > 	* gdb.base/sepdebug.exp: Likewise.
> > 	* gdb.base/unload.exp: Likewise.
> > 	* gdb.base/ovldbreak.exp: Likewise.
> > 
> > 
> > So I'm surprised that Vladimir did not know there would be more than those
> > in ovldbreak.exp (actually cp.base).
> 
> In my email, I've actually said I did not run the other tests and 
> there might be more failures.  Getting the complete list is only
> possible by running the testsuite, since I have no idea what tests were
> added since then.
> 
> > It is possible for me to try to understand each of these changes and revert
> > them but clearly it is far easier for Vladimir to do that as he made the
> > changes in the first place.
> > 
> > I will try to do that but I don't have the time at the moment.
> 
> So, given that we want to release 6.8 soon, and already spent considerable time
> on this patch, it looks like I get to pick up where you left. I'll try to
> update the test tomorrow.

I'm sorry that "tomorrow" did not happen. However, here's a patch with
adjusted tests, I don't see any regressions on x86. OK?

- Volodya

    [gdb]
    2008-02-15  Nick Roberts  <nickrob@snap.net.nz>

            * breakpoint.c (print_one_breakpoint_location): Revert Enb field
            to old format.  Discard breakpoint address if shared library is
            unloaded.
            (breakpoint_1): Adjust formatting of table header accordingly.

    [gdb/testsuite]
    2008-02-25  Vladimir Prus  <vladimir@codesourcery.com>

        * gdb.base/annota1.exp: Adjust for 'info break'
        format changes.
        * gdb.base/annota3.exp: Likewise.
        * gdb.base/break.exp: Likewise.
        * gdb.base/condbreak.exp: Likewise.
        * gdb.base/pending.exp: Likewise.
        * gdb.base/sepdebug.exp: Likewise.
        * gdb.base/unload.exp: Likewise.
        * gdb.cp/ovldbreak.exp: Likewise.
        * gdb.mi/mi-pending.exp: Likewise.