From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8450 invoked by alias); 20 Feb 2008 20:27:17 -0000 Received: (qmail 8442 invoked by uid 22791); 20 Feb 2008 20:27:16 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 20 Feb 2008 20:26:59 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1JRvWm-0004FI-8b for gdb-patches@sourceware.org; Wed, 20 Feb 2008 23:26:55 +0300 Received: from localhost ([127.0.0.1] helo=ip6-localhost) by zigzag.lvk.cs.msu.su with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1JRvVm-0004EN-8J; Wed, 20 Feb 2008 23:25:50 +0300 From: Vladimir Prus To: Nick Roberts Subject: Re: (gdb-6.8) Discard breakpoint address if shared library is unloaded Date: Wed, 20 Feb 2008 20:27:00 -0000 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: Joel Brobecker , gdb-patches@sourceware.org References: <20080204214226.GF20922@adacore.com> <20080220163125.GA3669@adacore.com> <18364.32147.39758.99346@kahikatea.snap.net.nz> In-Reply-To: <18364.32147.39758.99346@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200802202325.51341.ghost@cs.msu.su> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00340.txt.bz2 On Wednesday 20 February 2008 22:20:51 Nick Roberts wrote: > > So how about you submit a complete patch, following the usual protocol > > rather than an abbreviated one? I'll review it promptly, and we can > > put this episode behind us. As I said before, I reviewed the breakpoint.c > > patch and it looked fine, so it's just a matter of taking a look at > > the testsuite failures and adjust the testsuite accordingly (if > > justified). > > Some or all of the other failures occur in these files: > > 2007-09-23 Vladimir Prus > > * gdb.base/annota1.exp: Adjust for 'info break' > format changes. > * gdb.base/annota3.exp: Likewise. > * gdb.base/break.exp: Likewise. > * gdb.base/condbreak.exp: Likewise. > * gdb.base/pending.exp: Likewise. > * gdb.base/sepdebug.exp: Likewise. > * gdb.base/unload.exp: Likewise. > * gdb.base/ovldbreak.exp: Likewise. > > > So I'm surprised that Vladimir did not know there would be more than those > in ovldbreak.exp (actually cp.base). In my email, I've actually said I did not run the other tests and there might be more failures. Getting the complete list is only possible by running the testsuite, since I have no idea what tests were added since then. > It is possible for me to try to understand each of these changes and revert > them but clearly it is far easier for Vladimir to do that as he made the > changes in the first place. > > I will try to do that but I don't have the time at the moment. So, given that we want to release 6.8 soon, and already spent considerable time on this patch, it looks like I get to pick up where you left. I'll try to update the test tomorrow. - Volodya