From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7198 invoked by alias); 21 Feb 2008 00:09:05 -0000 Received: (qmail 7189 invoked by uid 22791); 21 Feb 2008 00:09:04 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 21 Feb 2008 00:08:47 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m1L08jiG020124 for ; Wed, 20 Feb 2008 19:08:45 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m1L08jfJ020573 for ; Wed, 20 Feb 2008 19:08:45 -0500 Received: from ironwood.lan (vpn-14-26.rdu.redhat.com [10.11.14.26]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m1L08iMZ025135 for ; Wed, 20 Feb 2008 19:08:45 -0500 Date: Thu, 21 Feb 2008 00:09:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [rfa/solib] Always reload DT_DEBUG, trust r_brk Message-ID: <20080220170844.243d3b8e@ironwood.lan> In-Reply-To: <20080208191111.GA30569@caradoc.them.org> References: <20080208191111.GA30569@caradoc.them.org> X-Mailer: Claws Mail 3.3.0 (GTK+ 2.12.5; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00342.txt.bz2 > 2008-02-08 Daniel Jacobowitz > > * mipsnbsd-tdep.c (mipsnbsd_ilp32_fetch_link_map_offsets): Set > r_brk_offset. > (mipsnbsd_lp64_fetch_link_map_offsets): Likewise. > * solib-svr4.c (solib_svr4_r_brk): New. > (open_symbol_file_object, svr4_current_sos): Always check the > debug base. > (svr4_fetch_objfile_link_map): Do not set debug_base. > (enable_break): Use r_brk if it is set. > (svr4_ilp32_fetch_link_map_offsets): Set r_brk_offset. > (svr4_lp64_fetch_link_map_offsets): Likewise. > * solib-svr4.h (struct link_map_offsets): Add r_brk_offset. These changes look reasonable to me. Go ahead and commit them. Kevin