Re: (gdb-6.8) Discard breakpoint address if shared library is unloaded

Nick Roberts
2008-02-19T20:04:29Z

Joel Brobecker writes:
> Nick,
>
> > 2008-02-15 Nick Roberts <nickrob@snap.net.nz>
> >
> > * breakpoint.c (print_one_breakpoint_location): Revert Enb field
> > to old format. Discard breakpoint address if shared library is
> > unloaded.
> > (breakpoint_1): Adjust formatting of table header accordingly.
>
> The patch looks fine, but I assumed that you had run the testsuite
> before sending it. From my end, it looks like you didn't, and I find
> this quite disappointing. Based on Volodya's email, I ran the testsuite
> myself (which I really shouldn't have to), and discovered that your
> patch causes ~20 new failures, not just the 3 that Volodya discovered.
>
> Your patch cannot go in until the failures are investigated and fixed.
>
> Please make sure to always confirm in your submissions that you did
> run the testsuite, mentioning which architecture it was run on, and
> also confirm that it did not introduce any regression.

I did run the whole testsuite on the first patch that I submitted which, as you
pointed out, was missing some detail which I had somehow lost since last
November, but not the amendment to that patch. You might find it disappointing
that I've not rerun the testsuite but I find it disappointing that I have had
to submit complete patches for code, doumentation and testsuite to revert
changes which I pointed out broke things for Emacs.

--
Nick http://www.inet.net.nz/~nickrob