From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31710 invoked by alias); 19 Feb 2008 19:02:07 -0000 Received: (qmail 31699 invoked by uid 22791); 19 Feb 2008 19:02:05 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 19 Feb 2008 19:01:48 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7AC0D2A9ACA; Tue, 19 Feb 2008 14:01:46 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id J20xyiJULw7b; Tue, 19 Feb 2008 14:01:46 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 430C52A9AC7; Tue, 19 Feb 2008 14:01:46 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id E6FFEE7ACB; Tue, 19 Feb 2008 11:01:43 -0800 (PST) Date: Tue, 19 Feb 2008 19:02:00 -0000 From: Joel Brobecker To: Nick Roberts Cc: Vladimir Prus , gdb-patches@sourceware.org Subject: Re: (gdb-6.8) Discard breakpoint address if shared library is unloaded Message-ID: <20080219190143.GH3713@adacore.com> References: <20080204214226.GF20922@adacore.com> <20080207063817.GA3907@adacore.com> <18347.45621.630420.453287@kahikatea.snap.net.nz> <200802080942.29622.ghost@cs.msu.su> <18348.1691.478013.310214@kahikatea.snap.net.nz> <20080214214246.GC3713@adacore.com> <18357.3708.628053.809241@kahikatea.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18357.3708.628053.809241@kahikatea.snap.net.nz> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00317.txt.bz2 Nick, > 2008-02-15 Nick Roberts > > * breakpoint.c (print_one_breakpoint_location): Revert Enb field > to old format. Discard breakpoint address if shared library is > unloaded. > (breakpoint_1): Adjust formatting of table header accordingly. The patch looks fine, but I assumed that you had run the testsuite before sending it. From my end, it looks like you didn't, and I find this quite disappointing. Based on Volodya's email, I ran the testsuite myself (which I really shouldn't have to), and discovered that your patch causes ~20 new failures, not just the 3 that Volodya discovered. Your patch cannot go in until the failures are investigated and fixed. Please make sure to always confirm in your submissions that you did run the testsuite, mentioning which architecture it was run on, and also confirm that it did not introduce any regression. -- Joel