Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Alan Modra <amodra@bigpond.net.au>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: PR5692
Date: Sat, 16 Feb 2008 23:01:00 -0000	[thread overview]
Message-ID: <20080216230042.GA7043@bubble.grove.modra.org> (raw)
In-Reply-To: <200802161619.m1GGJftU003725@d12av02.megacenter.de.ibm.com>

On Sat, Feb 16, 2008 at 05:19:41PM +0100, Ulrich Weigand wrote:
> This appears to fix the crash:
> 
> diff -c -p -r1.29 simple.c
> *** simple.c    10 Jul 2007 13:49:04 -0000      1.29
> --- simple.c    16 Feb 2008 16:17:50 -0000
> *************** bfd_simple_get_relocated_section_content
> *** 188,193 ****
> --- 188,194 ----
>     memset (&link_info, 0, sizeof (link_info));
>     link_info.input_bfds = abfd;
>     link_info.input_bfds_tail = &abfd->link_next;
> +   link_info.output_bfd = abfd;
> 
>     link_info.hash = _bfd_generic_link_hash_table_create (abfd);
>     link_info.callbacks = &callbacks;
> 
> However, I'm not sure this is really the right thing to do here ...

It is.  I have installed your fix.  Thanks!

-- 
Alan Modra
Australia Development Lab, IBM


      reply	other threads:[~2008-02-16 23:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080215034748.GA1840@bubble.grove.modra.org>
2008-02-16 16:20 ` PR5692 Ulrich Weigand
2008-02-16 23:01   ` Alan Modra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080216230042.GA7043@bubble.grove.modra.org \
    --to=amodra@bigpond.net.au \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox