From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20988 invoked by alias); 14 Feb 2008 21:15:54 -0000 Received: (qmail 20929 invoked by uid 22791); 14 Feb 2008 21:15:54 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 14 Feb 2008 21:15:34 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 133DE98140; Thu, 14 Feb 2008 21:15:33 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id DFC789811F; Thu, 14 Feb 2008 21:15:32 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JPlQZ-0004vH-VL; Thu, 14 Feb 2008 16:15:31 -0500 Date: Thu, 14 Feb 2008 21:15:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: --multi support for Windows targets (Re: [rfc] Multiple process support in gdbserver) Message-ID: <20080214211531.GA18905@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <20071207212352.GB32256@caradoc.them.org> <4797EEC9.10100@portugalmail.pt> <20080130005147.GA25780@caradoc.them.org> <200802142108.55820.pedro_alves@portugalmail.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200802142108.55820.pedro_alves@portugalmail.pt> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00238.txt.bz2 On Thu, Feb 14, 2008 at 09:08:55PM +0000, Pedro Alves wrote: > A Wednesday 30 January 2008 00:51:47, Daniel Jacobowitz wrote: > > On Thu, Jan 24, 2008 at 01:50:01AM +0000, Pedro Alves wrote: > > > > In addition to that, this almost works on Windows targets, we just > > > need to clean up the state when the inferiors are detached or > > > killed, like you're doing on linux. If you prefer, I can post a > > > patch once this goes in. > > > > Great! Yes, please do. > > Here it is. Basically, it's just clearing state and freeing heap > objects, since without --multi we didn't care much. Tested on > i686-pc-cygwin with a local gdbserver, no regressions. Without > this patch, --multi will only work the first run, the following > runs trip on variables with garbage on them. Looks OK to me. -- Daniel Jacobowitz CodeSourcery