From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7649 invoked by alias); 12 Feb 2008 13:26:24 -0000 Received: (qmail 7641 invoked by uid 22791); 12 Feb 2008 13:26:24 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 12 Feb 2008 13:25:58 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id E669198118; Tue, 12 Feb 2008 13:25:55 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id C9D8C9801D; Tue, 12 Feb 2008 13:25:55 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JOv90-0001If-Dp; Tue, 12 Feb 2008 08:25:54 -0500 Date: Tue, 12 Feb 2008 13:26:00 -0000 From: Daniel Jacobowitz To: Aleksandar Ristovski Cc: gdb-patches@sourceware.org Subject: Re: [patch] Do not add partial_symbol again and again to the list Message-ID: <20080212132554.GA4978@caradoc.them.org> Mail-Followup-To: Aleksandar Ristovski , gdb-patches@sourceware.org References: <20080211210935.GA31767@caradoc.them.org> <47B0C0F4.4090302@qnx.com> <20080211214750.GA1953@caradoc.them.org> <47B0C7C6.9090605@qnx.com> <20080211223056.GA3833@caradoc.them.org> <47B0CF8A.6080306@qnx.com> <20080211225314.GA5832@caradoc.them.org> <47B0F16B.9090308@qnx.com> <20080212021156.GA15744@caradoc.them.org> <47B12FF9.8080106@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47B12FF9.8080106@qnx.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00200.txt.bz2 On Tue, Feb 12, 2008 at 12:34:49AM -0500, Aleksandar Ristovski wrote: > What happens with the patch is that for an objfile, we will add global > type information only once, in the first partial symbol table where the > symbol was encountered. I think this will be fine. Type info will not have > address associated and all information we can get about it will be there. > Finding the first matching partial symbol for a type symbol is as good as > finding the second or N-th partial symbol for that type (and domain). Types are not (in C) global. They're file-static. We need to know which types are present in each file, because they may have different definitions in each file. The psymbols for two types with the same name will be the same. But the full symbols may be different. -- Daniel Jacobowitz CodeSourcery