From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11454 invoked by alias); 11 Feb 2008 22:53:47 -0000 Received: (qmail 11445 invoked by uid 22791); 11 Feb 2008 22:53:46 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 11 Feb 2008 22:53:18 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 9EBCA98036; Mon, 11 Feb 2008 22:53:16 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 646AB9801D; Mon, 11 Feb 2008 22:53:16 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JOhWU-0001cE-Sf; Mon, 11 Feb 2008 17:53:14 -0500 Date: Mon, 11 Feb 2008 22:53:00 -0000 From: Daniel Jacobowitz To: Aleksandar Ristovski Cc: gdb-patches@sourceware.org Subject: Re: [patch] Do not add partial_symbol again and again to the list Message-ID: <20080211225314.GA5832@caradoc.them.org> Mail-Followup-To: Aleksandar Ristovski , gdb-patches@sourceware.org References: <47B0AEC7.3070400@qnx.com> <20080211203809.GA29560@caradoc.them.org> <47B0B56F.4010607@qnx.com> <20080211210935.GA31767@caradoc.them.org> <47B0C0F4.4090302@qnx.com> <20080211214750.GA1953@caradoc.them.org> <47B0C7C6.9090605@qnx.com> <20080211223056.GA3833@caradoc.them.org> <47B0CF8A.6080306@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47B0CF8A.6080306@qnx.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00192.txt.bz2 On Mon, Feb 11, 2008 at 05:43:22PM -0500, Aleksandar Ristovski wrote: > If one compilation unit has a list of symbols and they appear more than > once... do we really need to have all duplicate records in partial symbols > list? The partial symbol lookup (by symbol name) will find only the first > one matching and probably cause loading the full symbols at which point > all works as before. Sure. But your patches aren't checking one compilation unit, they're checking every compilation unit in the objfile at once. That's why they found duplicates. I don't think any one compilation unit will have a duplicate. > Not sure if it is a valid indicator but I didn't have any regressions in > 'make check'. Yeah, I think I could write some testcases that were affected by this, but I'm not sure. It's tricky because if something else causes the full symtab to load, the problem won't appear. Maybe there's some way we can avoid needing psymbols for types at all. But I think we need to have a real design and some documentation for it instead of just accidentally omitting them. -- Daniel Jacobowitz CodeSourcery