From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27268 invoked by alias); 11 Feb 2008 21:09:59 -0000 Received: (qmail 27258 invoked by uid 22791); 11 Feb 2008 21:09:58 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 11 Feb 2008 21:09:39 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 502E998036; Mon, 11 Feb 2008 21:09:37 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id F05CD9801D; Mon, 11 Feb 2008 21:09:36 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JOfuB-0008Hd-TK; Mon, 11 Feb 2008 16:09:35 -0500 Date: Mon, 11 Feb 2008 21:09:00 -0000 From: Daniel Jacobowitz To: Aleksandar Ristovski Cc: gdb-patches@sourceware.org Subject: Re: [patch] Do not add partial_symbol again and again to the list Message-ID: <20080211210935.GA31767@caradoc.them.org> Mail-Followup-To: Aleksandar Ristovski , gdb-patches@sourceware.org References: <47B0AEC7.3070400@qnx.com> <20080211203809.GA29560@caradoc.them.org> <47B0B56F.4010607@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47B0B56F.4010607@qnx.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00185.txt.bz2 On Mon, Feb 11, 2008 at 03:51:59PM -0500, Aleksandar Ristovski wrote: > Daniel Jacobowitz wrote: >> On Mon, Feb 11, 2008 at 03:23:35PM -0500, Aleksandar Ristovski wrote: >>> The attached patch checks if partial_symbol has already been added to >>> the list instead of adding duplicate records. >> >> How does this ever happen? It seems very wrong. Also, I am worried >> that the linear search will be a bottleneck (this is quadratic as each >> psymtab grows). > > Yes, I understand your concern about the complexity... but... That's only part of the problem. You have this huge duplication of identical partial symbols within the same block. How did that happen? It shouldn't. Maybe we can avoid creating them in the first place. -- Daniel Jacobowitz CodeSourcery