From: Daniel Jacobowitz <drow@false.org>
To: Aleksandar Ristovski <aristovski@qnx.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC/patch] Sort global symbols in psymtabs only if needed
Date: Mon, 11 Feb 2008 16:43:00 -0000 [thread overview]
Message-ID: <20080211164335.GA15268@caradoc.them.org> (raw)
In-Reply-To: <47B075A2.5010207@qnx.com>
On Mon, Feb 11, 2008 at 11:19:46AM -0500, Aleksandar Ristovski wrote:
> The attached patch sorts on first lookup instead of on load.
Does this help if you benchmark any non-trivial debug sessions?
You've sped up startup, but the first call to lookup_symbol is going
to search a large number of such psymtabs.
Also, you probably know this, but be careful using gprof for this sort
of thing. I recommend oprofile. gprof artificially inflates the cost
of small frequent functions like strcmp_iw_ordered, because of all the
overhead.
The patch may still be a good idea. Can we eliminate the binary
search / sort entirely? We do hash table lookups for full symtabs;
that should be faster than sorting. See dict_create_hashed.
Those are all hardwired to "struct symbol" at the moment. But
I think it only uses SYMBOL_SEARCH_NAME, so it could work with
psymbols too if we passed the ginfo around.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-02-11 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 16:20 Aleksandar Ristovski
2008-02-11 16:43 ` Daniel Jacobowitz [this message]
2008-02-11 17:43 ` Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080211164335.GA15268@caradoc.them.org \
--to=drow@false.org \
--cc=aristovski@qnx.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox