From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit(Ada)] SEGV during symbol completion - VEC usage issue
Date: Thu, 07 Feb 2008 22:54:00 -0000 [thread overview]
Message-ID: <20080207225408.GA30696@caradoc.them.org> (raw)
In-Reply-To: <20080207222459.GF3907@adacore.com>
On Thu, Feb 07, 2008 at 02:24:59PM -0800, Joel Brobecker wrote:
> So I fixed the problem by turning parameter SV into a VEC**.
>
> 2008-02-07 Joel Brobecker <brobecker@adacore.com>
>
> * ada-lang.c (symbol_completion_add): Make SV parameter a VEC**
> instead of just a VEC*. Update use of SV.
> (ada_make_symbol_completion_list): Update symbol_completion_add calls.
>
> Tested on x86-linux, no regression. I'll commit now because it cures a SEGV
> that is easy to hit, but I'd appreciate a second pair of eyes...
Looks correct to me also.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2008-02-07 22:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-07 22:26 Joel Brobecker
2008-02-07 22:54 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080207225408.GA30696@caradoc.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox