From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10799 invoked by alias); 7 Feb 2008 18:14:11 -0000 Received: (qmail 10790 invoked by uid 22791); 7 Feb 2008 18:14:10 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 07 Feb 2008 18:13:49 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 16C7398391; Thu, 7 Feb 2008 18:13:48 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id F414698390; Thu, 7 Feb 2008 18:13:47 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JNBFr-0005b8-04; Thu, 07 Feb 2008 13:13:47 -0500 Date: Thu, 07 Feb 2008 18:14:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org, dje@google.com Subject: Re: [rfc] Use substitute-path for filename portion too Message-ID: <20080207181346.GA21484@caradoc.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org, dje@google.com References: <20080207174645.GA19452@caradoc.them.org> <20080207175658.GB3907@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080207175658.GB3907@adacore.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00132.txt.bz2 On Thu, Feb 07, 2008 at 09:56:58AM -0800, Joel Brobecker wrote: > > + > > + if (IS_ABSOLUTE_PATH (filename)) > > { > > - /* If dirname is NULL, chances are the path is embedded in > > - the filename. Try the source path substitution on it. */ > > + /* If filename is absolute path, try the source path > > + substitution on it. */ > > Do we want to restrict this to filenames that are absolute paths? > Imagine the filename was codesourcery/bar/bar.h and the rewrite was > s/codesourcery/adacore/, do we want to attempt the rewrite then? > I suppose we should wait to see a real example of such a situation > before trying to support it... Are such rules supported? I couldn't work out from the manual what FROM and TO had to be. -- Daniel Jacobowitz CodeSourcery