From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14258 invoked by alias); 3 Feb 2008 21:41:54 -0000 Received: (qmail 14249 invoked by uid 22791); 3 Feb 2008 21:41:53 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 03 Feb 2008 21:41:27 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id D8C6E98216; Sun, 3 Feb 2008 21:41:25 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 6EE6F98022; Sun, 3 Feb 2008 21:41:25 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JLmaa-0003Ev-0O; Sun, 03 Feb 2008 16:41:24 -0500 Date: Sun, 03 Feb 2008 21:41:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: Marc Khouzam , Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: [Patch] -var-evaluate-expression NAME [FORMAT] Message-ID: <20080203214123.GA12139@caradoc.them.org> Mail-Followup-To: Joel Brobecker , Marc Khouzam , Vladimir Prus , gdb-patches@sources.redhat.com References: <20080129214347.GC15063@caradoc.them.org> <6D19CA8D71C89C43A057926FE0D4ADAA04290E7D@ecamlmw720.eamcs.ericsson.se> <6D19CA8D71C89C43A057926FE0D4ADAA04E1BC29@ecamlmw720.eamcs.ericsson.se> <20080203204212.GC21614@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080203204212.GC21614@adacore.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00059.txt.bz2 On Sun, Feb 03, 2008 at 12:42:12PM -0800, Joel Brobecker wrote: > We usually prefer it if you do the reformatting in a separate patch. > It makes it easier to review the non-reformatting bits by not drowning > the meat of your patch with other, less critical, hunks. ... But now that it's done it's not worth undoing, IMO. -- Daniel Jacobowitz CodeSourcery