From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21115 invoked by alias); 1 Feb 2008 22:50:50 -0000 Received: (qmail 21067 invoked by uid 22791); 1 Feb 2008 22:50:49 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 01 Feb 2008 22:50:21 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1EC032A985B for ; Fri, 1 Feb 2008 17:50:19 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1GUnkzFfX+U5 for ; Fri, 1 Feb 2008 17:50:19 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A2A1A2A9821 for ; Fri, 1 Feb 2008 17:50:18 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 99BB9E7ACB; Fri, 1 Feb 2008 14:50:16 -0800 (PST) Date: Fri, 01 Feb 2008 22:50:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: [RFA/dwarf] save nested Ada subprograms as global symbol Message-ID: <20080201225016.GB4303@adacore.com> References: <20071227073938.GC10767@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071227073938.GC10767@adacore.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00038.txt.bz2 > 2007-12-27 Joel Brobecker > > * dwarf2read.c (add_partial_symbol): Always store all Ada subprograms > in the global scope. > (new_symbol): Likewise. > > Tested on x86-linux, no regression. OK to commit? > > I am also attaching a testcase that fails without this patch: > > 2007-12-27 Joel Brobecker > > * gdb.ada/nested/hello.adb: New file. > * gdb.ada/nested.exp: New testcase. > * gdb.ada/Makefile.in (EXECUTABLES): Update list. Just to confirm that this one has now been checked in. (thanks, Daniel) -- Joel