From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1235 invoked by alias); 31 Jan 2008 22:43:17 -0000 Received: (qmail 1226 invoked by uid 22791); 31 Jan 2008 22:43:17 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 31 Jan 2008 22:42:54 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 57D352A9B4E for ; Thu, 31 Jan 2008 17:42:52 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id c46JnJ82QS5g for ; Thu, 31 Jan 2008 17:42:52 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 07B5D2A9665 for ; Thu, 31 Jan 2008 17:42:52 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id B73BAE7ACB; Thu, 31 Jan 2008 14:42:49 -0800 (PST) Date: Thu, 31 Jan 2008 22:59:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: [RFC/RFA?] Should break FILE:LINENO skip prologue? Message-ID: <20080131224249.GC21235@adacore.com> References: <20080109151745.GA13181@adacore.com> <20080131220814.GB6326@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080131220814.GB6326@caradoc.them.org> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00882.txt.bz2 > > 2008-01-09 Joel Brobecker > > > > * breakpoint.c (skip_prologue_sal): New function. > > (resolve_sal_pc): Adjust SAL past prologue if the SAL was > > computed from a line number. > > I tried to reread the thread below this patch, but eventually got > lost. What was the verdict? Everyone pretty much agreed :). I should have sent a message earlier, but you've kept me busy with the other patches I've sent ;-). I'm ready to commit now, but we'll need to adjust the testsuite at a few places, I think. I can take care of that either today or tomorrow. -- Joel