Re: [gdbserver] Make mingw32ce gdbserver build again

[Daniel Jacobowitz <drow@false.org>]

On Thu, Jan 31, 2008 at 05:58:15PM +0000, Pedro Alves wrote:
> gdbserver/
> 2008-01-31  Pedro Alves  <pedro_alves@portugalmail.pt>
> 
> 	* hostio.c: Don't include errno.h.
> 	(errno_to_fileio_errno): Move to hostio-errno.
> 	* hostio.c: (hostio_error): Remove the error parameter.  Defer the
> 	error number outputting to the target->hostio_last_error callback.
> 	(hostio_packet_error): Use FILEIO_EINVAL directly.
> 	(handle_open, handle_pread, hostio_error, handle_unlink): Update
> 	calls to hostio_error.
> 	* hostio-errno.c: New.
> 	* server.h (hostio_last_error_from_errno): Declare.
> 	* target.h (target_ops): Add hostio_last_error member.
> 	* linux-low.c (linux_target_op): Register hostio_last_error_from_errno
> 	as hostio_last_error handler.
> 	* spu-low.c (spu_target_ops): Likewise. 
> 	* win32-low.c [_WIN32_WCE] (win32_error_to_fileio_error,
> 	wince_hostio_last_error): New functions.
> 	(win32_target_ops) [_WIN32_WCE]: Register wince_hostio_last_error
> 	as hostio_last_error handler.
> 	(win32_target_ops) [!_WIN32_WCE]: Register
> 	hostio_last_error_from_errno as hostio_last_error handler.
> 	* Makefile.in (SFILES): Add hostio.c and hostio-errno.c.
> 	(hostio-errno.o): New rule.
> 	* configure.ac (GDBSERVER_DEPFILES): Add $srv_hostio_err_objs.
> 	* configure.srv (srv_hostio_err_objs): New variable.  Default to
> 	hostio-errno.o.
> 	(arm*-*-mingw32ce*): Set srv_hostio_err_objs to "".
> 	* configure: Regenerate.

OK.
> Index: src/gdb/gdbserver/hostio-errno.c
> ===================================================================
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ src/gdb/gdbserver/hostio-errno.c	2008-01-31 17:50:02.000000000 +0000
> @@ -0,0 +1,64 @@
> +#include <errno.h>

This file needs a copyright notice.

> +{
> +  int error = errno;
> +  int fileio_error = errno_to_fileio_error (error);
> +  sprintf (buf, "F-1,%x", fileio_error);
> +  errno = error; /* preserve errno */

No need to preserve errno.

-- 
Daniel Jacobowitz
CodeSourcery