From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28416 invoked by alias); 30 Jan 2008 21:26:31 -0000 Received: (qmail 28406 invoked by uid 22791); 30 Jan 2008 21:26:30 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 30 Jan 2008 21:26:13 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.1/8.14.1) with ESMTP id m0ULILXm006536; Wed, 30 Jan 2008 22:18:21 +0100 (CET) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.1/8.14.1/Submit) id m0ULILq9032726; Wed, 30 Jan 2008 22:18:21 +0100 (CET) Date: Wed, 30 Jan 2008 21:42:00 -0000 Message-Id: <200801302118.m0ULILq9032726@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: bauerman@br.ibm.com CC: drow@false.org, luisgpm@linux.vnet.ibm.com, gdb-patches@sourceware.org In-reply-to: <1201726975.11950.270.camel@localhost.localdomain> (message from Thiago Jung Bauermann on Wed, 30 Jan 2008 19:02:55 -0200) Subject: Re: Printing decimal128 types out of registers References: <1200927274.32125.36.camel@localhost.localdomain> <200801211730.m0LHUGbu021315@brahms.sibelius.xs4all.nl> <1194460412.6686.34.camel@localhost> <1200596592.27321.20.camel@gargoyle> <1200598580.32125.11.camel@localhost.localdomain> <1200670954.10815.1.camel@gargoyle> <20080119000423.GA15057@caradoc.them.org> <1200927274.32125.36.camel@localhost.localdomain> <20080121175413.GA25254@caradoc.them.org> <1201101039.11950.56.camel@localhost.localdomain> <20080123152007.GA8286@caradoc.them.org> <1201706206.11950.237.camel@localhost.localdomain> <200801301811.m0UIBJS0006582@brahms.sibelius.xs4all.nl> <1201717824.11950.252.camel@localhost.localdomain> <200801301852.m0UIqMoo009713@brahms.sibelius.xs4all.nl> <1201726975.11950.270.camel@localhost.localdomain> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00831.txt.bz2 > From: Thiago Jung Bauermann > Date: Wed, 30 Jan 2008 19:02:55 -0200 > > On Wed, 2008-01-30 at 19:52 +0100, Mark Kettenis wrote: > > > From: Thiago Jung Bauermann > > > ppc_dl0_upper_regnum is used ppc_pseudo_register_{read,write}. Are you > > > saying that given it always has the value of ppc_fp0_regnum, I should > > > use that instead? Could be, but then there's the lack of symmetry in > > > using an fp variable in dl-related code. But that's minor. > > > > Yes, I think that using ppc_fp0_regnum is better, since it makes it > > explicit in the code that the decimal float (pseudo) registers are > > just a different representation of the floating point registers. > > > > > ppcdl15_regnum is indeed unused. I kept it also for symmetry reasons, > > > since there's ppc_ev31_regnum. But it can be removed (specially if the > > > later is removed as well as you suggested). > > > > Yes, that was what I was thinking. The less uneeded clutter, the better. > > Ok, removed those. I also refreshed it against the reworked SPE macro > cleanup patch. What about this? Looks fine to me (as does the SPE macro cleanup diff). > 2008-01-30 Luis Machado > Thiago Jung Bauermann > > gdb/ > * infcmd.c (default_print_registers_info): Also print hex > raw contents for TYPE_CODE_DECFLOAT registers. > * ppc-tdep.h (gdbarch_tdep): Add ppc_dl0_regnum member. > * rs6000-tdep.c (IS_DFP_PSEUDOREG): New macro. > (rs6000_register_name): Add support for DFP pseudo-registers. > (rs6000_pseudo_register_type): Likewise. > rs6000_pseudo_register_reggroup_p): Likewise. > (ppc_pseudo_register_read): New function. > (ppc_pseudo_register_write): Likewise. > (rs6000_pseudo_register_read): Likewise. > (rs6000_pseudo_register_write): Likewise. > (e500_pseudo_register_read): Move checks to > rs6000_pseudo_register_read. > (e500_pseudo_register_write): Move checks to > rs6000_pseudo_register_write. > (rs6000_gdbarch_init): Initialize tdep->ppc_dl0_regnum. Install > rs6000_pseudo_register_read and rs6000_pseudo_register_write > in gdbarch if SPE or DFP is available. Adjust gdbarch's > num_pseudo_regs to account for DFP pseudo regs. > > gdb/testsuite/ > * gdb.arch/powerpc-d128-regs.exp: New testcase expect file. > * gdb.arch/powerpc-d128-regs.c: New testcase source file. > > gdb/doc/ > * gdb.texinfo: (Decimal Floating Point): Mention pseudo-registers > available in PowerPC architecture. > (Embedded Processors): Change node name of PowerPC item in menu. > (PowerPC): Rename to... > (PowerPC Embedded): this. > (Architectures): Add new PowerPC item in menu. > (PowerPC): New node.