From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-53788-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11260 invoked by alias); 30 Jan 2008 18:53:25 -0000
Received: (qmail 11250 invoked by uid 22791); 30 Jan 2008 18:53:24 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 30 Jan 2008 18:53:07 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.1) with ESMTP id m0UIr1Rx019963; 	Wed, 30 Jan 2008 19:53:01 +0100 (CET)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.1/Submit) id m0UIr0Ii025415; 	Wed, 30 Jan 2008 19:53:00 +0100 (CET)
Date: Wed, 30 Jan 2008 19:06:00 -0000
Message-Id: <200801301853.m0UIr0Ii025415@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: bauerman@br.ibm.com
CC: gdb-patches@sourceware.org
In-reply-to: <1201717972.11950.255.camel@localhost.localdomain> (message from 	Thiago Jung Bauermann on Wed, 30 Jan 2008 16:32:52 -0200)
Subject: Re: [RFA] Put SPE verification in macro.
References: <1201705759.11950.228.camel@localhost.localdomain> 	 <200801301814.m0UIE006010057@brahms.sibelius.xs4all.nl> <1201717972.11950.255.camel@localhost.localdomain>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-01/txt/msg00820.txt.bz2

> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Date: Wed, 30 Jan 2008 16:32:52 -0200
> 
> On Wed, 2008-01-30 at 19:14 +0100, Mark Kettenis wrote:
> > > From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> > > Date: Wed, 30 Jan 2008 13:09:19 -0200
> > > 
> > > The above code checks if ppc_ev31_regnum is >= 0 and if regno <=
> > > ppc_ev31_regnum. Since ppc_ev31_regnum is set in the same place and
> > > condition that ppc_ev0_regnum is set, and that ppc_ev31_regnum's
> > value
> > > is ppc_ev0_regnum + 31, those checks are equivalent to the ones made
> > by
> > > the new macro.
> > 
> > This makes ppc_ev31_regnum completely redundant isn't it?  Could you
> > remove it?
> 
> Right. Yes, I can remove it. I also noticed that the num_sprs variable
> in rs6000_gdbarch_init is set to zero and used without any other
> assignment. I will remove that one as well...

Sounds great!