From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31288 invoked by alias); 30 Jan 2008 19:24:51 -0000 Received: (qmail 31280 invoked by uid 22791); 30 Jan 2008 19:24:51 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 30 Jan 2008 19:24:28 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.1/8.14.1) with ESMTP id m0UIqNlG006059; Wed, 30 Jan 2008 19:52:23 +0100 (CET) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.1/8.14.1/Submit) id m0UIqMoo009713; Wed, 30 Jan 2008 19:52:22 +0100 (CET) Date: Wed, 30 Jan 2008 20:28:00 -0000 Message-Id: <200801301852.m0UIqMoo009713@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: bauerman@br.ibm.com CC: drow@false.org, luisgpm@linux.vnet.ibm.com, gdb-patches@sourceware.org In-reply-to: <1201717824.11950.252.camel@localhost.localdomain> (message from Thiago Jung Bauermann on Wed, 30 Jan 2008 16:30:24 -0200) Subject: Re: Printing decimal128 types out of registers References: <1200927274.32125.36.camel@localhost.localdomain> <200801211730.m0LHUGbu021315@brahms.sibelius.xs4all.nl> <1194460412.6686.34.camel@localhost> <1200596592.27321.20.camel@gargoyle> <1200598580.32125.11.camel@localhost.localdomain> <1200670954.10815.1.camel@gargoyle> <20080119000423.GA15057@caradoc.them.org> <1200927274.32125.36.camel@localhost.localdomain> <20080121175413.GA25254@caradoc.them.org> <1201101039.11950.56.camel@localhost.localdomain> <20080123152007.GA8286@caradoc.them.org> <1201706206.11950.237.camel@localhost.localdomain> <200801301811.m0UIBJS0006582@brahms.sibelius.xs4all.nl> <1201717824.11950.252.camel@localhost.localdomain> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00823.txt.bz2 > From: Thiago Jung Bauermann > Cc: drow@false.org, luisgpm@linux.vnet.ibm.com, gdb-patches@sourceware.org > Date: Wed, 30 Jan 2008 16:30:24 -0200 > X-XS4ALL-DNSBL-Checked: mxdrop125.xs4all.nl checked 32.104.18.26 against DNS blacklists > X-CNFS-Analysis: v=1.0 c=1 a=IUiVJ43dWc4A:15 a=QNG5IYMOGygA:10 > a=32zfua8Jo/FoLADJBaZU6A==:17 a=TUX4L2OknBXofI9ZbzkA:9 > a=kQGOXI3pO-Bphn8UE8AA:7 a=lLSZ6TJ2nqydr84DMUAV6pK8bCYA:4 > a=LY0hPdMaydYA:10 > X-Virus-Scanned: by XS4ALL Virus Scanner > X-XS4ALL-Spam-Score: -0.0 () SPF_PASS > X-XS4ALL-Spam: NO > Envelope-To: mark.kettenis@xs4all.nl > > On Wed, 2008-01-30 at 19:11 +0100, Mark Kettenis wrote: > > > Is this ok? > > > > Looks mostly reasonable to me, but I don't see why you need > > ppc_dl0_upper_regnum, and ppc_dl15_regnum. > > ppc_dl0_upper_regnum is used ppc_pseudo_register_{read,write}. Are you > saying that given it always has the value of ppc_fp0_regnum, I should > use that instead? Could be, but then there's the lack of symmetry in > using an fp variable in dl-related code. But that's minor. Yes, I think that using ppc_fp0_regnum is better, since it makes it explicit in the code that the decimal float (pseudo) registers are just a different representation of the floating point registers. > ppcdl15_regnum is indeed unused. I kept it also for symmetry reasons, > since there's ppc_ev31_regnum. But it can be removed (specially if the > later is removed as well as you suggested). Yes, that was what I was thinking. The less uneeded clutter, the better.