From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28928 invoked by alias); 30 Jan 2008 03:04:58 -0000 Received: (qmail 28918 invoked by uid 22791); 30 Jan 2008 03:04:57 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 30 Jan 2008 03:04:37 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 7C46898151; Wed, 30 Jan 2008 03:04:35 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 568B09811F; Wed, 30 Jan 2008 03:04:35 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JK3Fa-0003bE-II; Tue, 29 Jan 2008 22:04:34 -0500 Date: Wed, 30 Jan 2008 03:06:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sourceware.org Subject: Re: [PATCH: mi-cmd-file.c] Message-ID: <20080130030434.GA13818@caradoc.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sourceware.org References: <18309.37153.798074.919481@kahikatea.snap.net.nz> <20080129180629.GI3773@caradoc.them.org> <18335.55189.966269.492998@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18335.55189.966269.492998@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00756.txt.bz2 On Wed, Jan 30, 2008 at 02:49:09PM +1300, Nick Roberts wrote: > > > 2008-01-10 Nick Roberts > > > > > > * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Add field > > > for preprocessor macro information. > > > > Needs a manual update, of course. Otherwise looks OK to me. > > > > GUD uses this to avoid expanding macros if it knows they are not > > available, right? > > Actually Emacs turns tooltips off if there is no macro information in case > of something like: > > #define STOP abort () > > and the mouse hovers over STOP. Macro information allows Emacs to ensure that > a macro doesn't expand to a function first. Hmm, that sounds silly. If there's no macro information, GDB won't be able to expand STOP to a function... > I've committed it with the formatting changes below as obvious. OK - be sure to do the manual update. -- Daniel Jacobowitz CodeSourcery