Re: generic code duplication in Ada files

Daniel Jacobowitz
2008-01-29T22:41:58Z

On Tue, Jan 29, 2008 at 02:33:42PM -0800, Joel Brobecker wrote:
> Daniel is a bit concerned by the code duplication that is occurring
> inside the Ada files (mostly ada-lang.c I believe). Because it's been
> the status quo for a while, Daniel didn't reject some patches I recently
> submitted, but I certainly heard his comments. Let me try to open up
> my mind a bit, and see if that might answer some of those concerns.

I came across angrier than I really felt, by the way. I apologize.

> We can make happen in the relatively near future. Doing it the other
> way will take, I am afraid, quite a bit of time. The cost of compromise
> is the semi-duplication that we have now. I can see that it can cause
> some maintenance trouble. But I promise in return that I will help
> in any way I can: fix the maintenance situations that might arise,
> and improve the situation in the long run.

This is exactly what I was hoping for. The duplication has been
status quo for many years; I don't mind it continuing that way, and
once we're in sync you'll have the option of doing restructuring on
the FSF tree, getting it right, and then importing it into your local
sources - much more palatable.

> Typically, my work-flow would involve doing the cleanup in the FSF
> tree, get it reviewed and checked in, and then push it to our tree.
> That way, I'm sure that any change I make finds its way to the FSF
> tree rapidly instead of sitting in our tree first, sometimes forever.

Hey, I hadn't even read this paragraph yet and I've already suggested
the same thing above! Great!

> So, any objection if I took advantage of the current status-quo for
> a little while longer? There are no more patches coming except
> the ones that are still under review, so we're close to the end
> of the tunnel.

And that's what I was going to ask. Also great. As long as the file
is not growing unboundedly, we're making progress :-)

Some of the things in Ada-specific code will be a mess to get into
common code, but IMO clearly worthwhile. For instance, a version of
symbol lookup which can return more than one symbol.

--
Daniel Jacobowitz
CodeSourcery