From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25450 invoked by alias); 29 Jan 2008 23:50:26 -0000 Received: (qmail 25441 invoked by uid 22791); 29 Jan 2008 23:50:25 -0000 X-Spam-Check-By: sourceware.org Received: from tully.CS.Berkeley.EDU (HELO tully.CS.Berkeley.EDU) (128.32.153.206) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 29 Jan 2008 23:50:08 +0000 Received: from tully.CS.Berkeley.EDU (localhost [127.0.0.1]) by tully.CS.Berkeley.EDU (8.13.8+Sun/8.13.8) with ESMTP id m0TNnVaV025063; Tue, 29 Jan 2008 15:49:32 -0800 (PST) Message-Id: <200801292349.m0TNnVaV025063@tully.CS.Berkeley.EDU> To: Daniel Jacobowitz cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: generic code duplication in Ada files Reply-To: Hilfinger@CS.Berkeley.EDU In-reply-to: Your message of Tue, 29 Jan 2008 17:41:23 -0500. <20080129224123.GA6586@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <25059.1201650571.1@tully.CS.Berkeley.EDU> Date: Tue, 29 Jan 2008 23:53:00 -0000 From: Paul Hilfinger Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00745.txt.bz2 > Some of the things in Ada-specific code will be a mess to get into > common code, but IMO clearly worthwhile. For instance, a version of > symbol lookup which can return more than one symbol. I am glad to hear you say that. Our original reason for this duplication, as you probably guessed, was to avoid disturbing core GDB "merely" for the sake of accommodating a less-familiar language. Our assumption was that any major maintenance headaches that resulted would be our problem. But apart from this political motivation, a major refactoring at this point would clearly be beneficial. Paul Hilfinger