Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Use vector for varobj_list_children interface.
Date: Tue, 29 Jan 2008 21:54:00 -0000	[thread overview]
Message-ID: <20080129215240.GG15063@caradoc.them.org> (raw)
In-Reply-To: <200801171755.47572.vladimir@codesourcery.com>

On Thu, Jan 17, 2008 at 05:55:47PM +0300, Vladimir Prus wrote:
> +  for (ix = 0; VEC_iterate (varobj_p, children, ix, child); ++ix)
>      {
>        struct cleanup *cleanup_child;
>        cleanup_child = make_cleanup_ui_out_tuple_begin_end (uiout, "child");
> -      print_varobj (*cc, print_values, 1 /* print expression */);
> -      cc++;
> +      print_varobj (child, print_values, 1 /* print expression */);
>        do_cleanups (cleanup_child);
>      }
>    do_cleanups (cleanup_children);
> -  xfree (childlist);
>    return MI_CMD_DONE;
>  }

Not freeing children here is on purpose, right?  It's now the copy
from inside the varobj.

> -int
> -varobj_list_children (struct varobj *var, struct varobj ***childlist)
> +VEC(varobj_p)*

Space there :-)

> +varobj_list_children (struct varobj *var)

> -extern int varobj_list_children (struct varobj *var,
> -				 struct varobj ***childlist);
> +extern VEC(varobj_p)* varobj_list_children (struct varobj *var);

Space there too.

Otherwise OK, thanks.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-01-29 21:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17 14:56 Vladimir Prus
2008-01-29 21:54 ` Daniel Jacobowitz [this message]
2008-01-30  7:22   ` Vladimir Prus
2008-01-30  8:31     ` Pierre Muller
2008-01-30  8:40       ` Vladimir Prus
2008-01-30  8:48         ` Pierre Muller
2008-01-30 13:52           ` Daniel Jacobowitz
2008-01-30 13:57             ` Vladimir Prus
2008-01-30 14:05               ` Daniel Jacobowitz
2008-01-30 14:17                 ` Daniel Jacobowitz
2008-01-30 15:09                 ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080129215240.GG15063@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox