Re: [PATCH: mi-cmd-file.c]

Nick Roberts
2008-01-30T01:49:42Z

> > 2008-01-10 Nick Roberts <nickrob@snap.net.nz>
> >
> > * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Add field
> > for preprocessor macro information.
>
> Needs a manual update, of course. Otherwise looks OK to me.
>
> GUD uses this to avoid expanding macros if it knows they are not
> available, right?

Actually Emacs turns tooltips off if there is no macro information in case
of something like:

#define STOP abort ()

and the mouse hovers over STOP. Macro information allows Emacs to ensure that
a macro doesn't expand to a function first.

I've committed it with the formatting changes below as obvious.

Thanks.

--
Nick http://www.inet.net.nz/~nickrob

2008-01-30 Nick Roberts <nickrob@snap.net.nz>

* mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Add field
for preprocessor macro information. Formatting changes.

*** mi-cmd-file.c.~1.7.~ 2008-01-04 10:24:34.000000000 +1300
--- mi-cmd-file.c 2008-01-10 16:15:10.000000000 +1300
***************
*** 29,46 ****
current file being executed. */

enum mi_cmd_result
! mi_cmd_file_list_exec_source_file(char *command, char **argv, int argc)
{
struct symtab_and_line st;
int optind = 0;
char *optarg;

! if ( !mi_valid_noargs("mi_cmd_file_list_exec_source_file", argc, argv) )
error (_("mi_cmd_file_list_exec_source_file: Usage: No args"));

/* Set the default file and line, also get them */
! set_default_source_symtab_and_line();
! st = get_current_source_symtab_and_line();

/* We should always get a symtab.
Apparently, filename does not need to be tested for NULL.
--- 29,46 ----
current file being executed. */

enum mi_cmd_result
! mi_cmd_file_list_exec_source_file (char *command, char **argv, int argc)
{
struct symtab_and_line st;
int optind = 0;
char *optarg;

! if (!mi_valid_noargs ("mi_cmd_file_list_exec_source_file", argc, argv))
error (_("mi_cmd_file_list_exec_source_file: Usage: No args"));

/* Set the default file and line, also get them */
! set_default_source_symtab_and_line ();
! st = get_current_source_symtab_and_line ();

/* We should always get a symtab.
Apparently, filename does not need to be tested for NULL.
*************** mi_cmd_file_list_exec_source_file(char *
*** 59,64 ****
--- 59,66 ----
if (st.symtab->fullname)
ui_out_field_string (uiout, "fullname", st.symtab->fullname);

+ ui_out_field_int (uiout, "macro-info", st.symtab->macro_table ? 1 : 0);
+
return MI_CMD_DONE;
}