From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4049 invoked by alias); 29 Jan 2008 15:17:48 -0000 Received: (qmail 4040 invoked by uid 22791); 29 Jan 2008 15:17:47 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 29 Jan 2008 15:17:20 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 0850A983D1; Tue, 29 Jan 2008 15:17:18 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 61E5298234; Tue, 29 Jan 2008 15:17:17 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JJsD5-0007Ul-Px; Tue, 29 Jan 2008 10:17:15 -0500 Date: Tue, 29 Jan 2008 15:23:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: Jim Blandy , gdb-patches@sources.redhat.com Subject: Re: [RFA] Don't reset watchpoint block on solib load. Message-ID: <20080129151715.GA28121@caradoc.them.org> Mail-Followup-To: Vladimir Prus , Jim Blandy , gdb-patches@sources.redhat.com References: <200711202013.47537.vladimir@codesourcery.com> <200711281858.51145.vladimir@codesourcery.com> <200801231257.27977.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200801231257.27977.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00677.txt.bz2 On Wed, Jan 23, 2008 at 12:57:27PM +0300, Vladimir Prus wrote: > So, I guess the solutions are either: > > 1. Omit the move of condition parsing from this patch, or > 2. Keep condition parsing in this patch, and then commit > the use-multiple-locations-for-watchpoint patch which will > immediately make condition only reparsed when breakpoint_re_set_one > is called. > > Given that use-multiple-locations-for-watchpoint patch is > approved except for the bit that makes reparsing of condition > optional, it seems that (2) is less work. All this sounds fine to me. I'm OK with this patch, which I believe is the one here: http://sourceware.org/ml/gdb-patches/2007-11/msg00522.html > For convenience, I attach the current version of > use-multiple-locations-for-watchpoint patch. The difference > to the previous revision is as follows: > > > @@ -966,7 +966,7 @@ update_watchpoint (struct breakpoint *b, int reparse) > value_free (v); > } > > - if (b->cond_string != NULL) > + if (reparse && b->cond_string != NULL) > { > char *s = b->cond_string; > if (b->loc->cond) > > > Dan, is the patch still OK to commit? Yes, it is. -- Daniel Jacobowitz CodeSourcery