From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13037 invoked by alias); 25 Jan 2008 17:05:47 -0000 Received: (qmail 13028 invoked by uid 22791); 25 Jan 2008 17:05:47 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 25 Jan 2008 17:05:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3251D2A9683; Fri, 25 Jan 2008 12:05:14 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id mcAbcz78jPx7; Fri, 25 Jan 2008 12:05:14 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id DCF952A9678; Fri, 25 Jan 2008 12:05:13 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 9956EE7ACB; Fri, 25 Jan 2008 09:05:11 -0800 (PST) Date: Fri, 25 Jan 2008 17:26:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: muller@ics.u-strasbg.fr, gdb-patches@sourceware.org Subject: Re: [RFA] i386-tdep.c: Add i386_skip_noop function; updated Message-ID: <20080125170511.GR23576@adacore.com> References: <000001c83b4a$573b4560$05b1d020$@u-strasbg.fr> <200712101854.lBAIs91J031646@brahms.sibelius.xs4all.nl> <002701c83be2$ac2a9a60$047fcf20$@u-strasbg.fr> <003101c85696$6f4d9e20$4de8da60$@u-strasbg.fr> <200801241750.m0OHoD5k007103@brahms.sibelius.xs4all.nl> <004701c85f53$2ef82dc0$8ce88940$@u-strasbg.fr> <20080125161247.GJ3979@adacore.com> <000001c85f70$9a33c8c0$ce9b5a40$@u-strasbg.fr> <200801251651.m0PGpP4Q010088@brahms.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200801251651.m0PGpP4Q010088@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00617.txt.bz2 > > Joel, > > I took your suggestions into account. > > > > I hope this sounds better for everyone. > > Sorry Pierre, but I relly liked your origional diff better (the one > that I reviewed yesterday). Could you commit that one? I'll clean up > the comments a bit after that. Sorry Pierre and Mark for causing extra work. -- Joel