From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5483 invoked by alias); 25 Jan 2008 16:51:55 -0000 Received: (qmail 5473 invoked by uid 22791); 25 Jan 2008 16:51:54 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 25 Jan 2008 16:51:36 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.1/8.14.1) with ESMTP id m0PGpQQk004614; Fri, 25 Jan 2008 17:51:26 +0100 (CET) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.1/8.14.1/Submit) id m0PGpP4Q010088; Fri, 25 Jan 2008 17:51:25 +0100 (CET) Date: Fri, 25 Jan 2008 17:05:00 -0000 Message-Id: <200801251651.m0PGpP4Q010088@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: muller@ics.u-strasbg.fr CC: brobecker@adacore.com, mark.kettenis@xs4all.nl, gdb-patches@sourceware.org In-reply-to: <000001c85f70$9a33c8c0$ce9b5a40$@u-strasbg.fr> (muller@ics.u-strasbg.fr) Subject: Re: [RFA] i386-tdep.c: Add i386_skip_noop function; updated References: <000001c83b4a$573b4560$05b1d020$@u-strasbg.fr> <200712101854.lBAIs91J031646@brahms.sibelius.xs4all.nl> <002701c83be2$ac2a9a60$047fcf20$@u-strasbg.fr> <003101c85696$6f4d9e20$4de8da60$@u-strasbg.fr> <200801241750.m0OHoD5k007103@brahms.sibelius.xs4all.nl> <004701c85f53$2ef82dc0$8ce88940$@u-strasbg.fr> <20080125161247.GJ3979@adacore.com> <000001c85f70$9a33c8c0$ce9b5a40$@u-strasbg.fr> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00616.txt.bz2 > From: "Pierre Muller" > Date: Fri, 25 Jan 2008 17:37:40 +0100 > > Joel, > I took your suggestions into account. > > I hope this sounds better for everyone. Sorry Pierre, but I relly liked your origional diff better (the one that I reviewed yesterday). Could you commit that one? I'll clean up the comments a bit after that.