From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10059 invoked by alias); 24 Jan 2008 21:49:17 -0000 Received: (qmail 10050 invoked by uid 22791); 24 Jan 2008 21:49:17 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 24 Jan 2008 21:48:53 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D785C2A966E; Thu, 24 Jan 2008 16:48:51 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id FJnBUKuyAl-m; Thu, 24 Jan 2008 16:48:51 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9B1842A9665; Thu, 24 Jan 2008 16:48:51 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 713ACE7ACB; Thu, 24 Jan 2008 13:48:49 -0800 (PST) Date: Thu, 24 Jan 2008 22:19:00 -0000 From: Joel Brobecker To: Pedro Alves , Jim Blandy , gdb-patches Subject: Re: arm_addr_bits_remove Message-ID: <20080124214849.GF3979@adacore.com> References: <47965D31.3040602@codesourcery.com> <8f2776cb0801221525w1d26661dgf6452f876197a591@mail.gmail.com> <479752C8.8030201@portugalmail.pt> <8f2776cb0801231121r3fe9aea0q6f3c3d6887fcb251@mail.gmail.com> <20080123192842.GA22477@caradoc.them.org> <8f2776cb0801231311o19c31781h8a4663c405bcd22b@mail.gmail.com> <479819E2.1030603@portugalmail.pt> <8f2776cb0801232227n64502d4akef4642b051e77772@mail.gmail.com> <4798871B.4080207@codesourcery.com> <20080124133844.GA15771@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080124133844.GA15771@caradoc.them.org> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00595.txt.bz2 > > 2008-01-24 Pedro Alves > > > > * buildsym.c (record_line): Don't try to strip unused addr bits. > If you're daring enough, this is OK - this could affect any target > defining gdbarch_addr_bits_remove so keep an eye out in case hppa, > m88k, mips, or s390 break. Please wait another day before checking it > in, in case someone else knows more about it. I just ran the testsuite on hppa and mips-irix, no regression. It might not come as a surprise given that the patch is removing something that handles what amounts to incorrect debugging info, but it's better than nothing. In both case, we use GNU and the system linker. -- Joel