From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22335 invoked by alias); 23 Jan 2008 14:42:13 -0000 Received: (qmail 22288 invoked by uid 22791); 23 Jan 2008 14:42:12 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 23 Jan 2008 14:40:08 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 4BCB298375; Wed, 23 Jan 2008 14:40:07 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 2BB90980E0; Wed, 23 Jan 2008 14:40:06 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JHglq-0001XN-38; Wed, 23 Jan 2008 09:40:06 -0500 Date: Wed, 23 Jan 2008 14:42:00 -0000 From: Daniel Jacobowitz To: Marc Khouzam Cc: Nick Roberts , gdb-patches@sourceware.org Subject: Re: [Patch] -var-evaluate-expression NAME [FORMAT] Message-ID: <20080123144006.GA5885@caradoc.them.org> Mail-Followup-To: Marc Khouzam , Nick Roberts , gdb-patches@sourceware.org References: <18326.44682.805865.581205@kahikatea.snap.net.nz> <6D19CA8D71C89C43A057926FE0D4ADAA04290E54@ecamlmw720.eamcs.ericsson.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6D19CA8D71C89C43A057926FE0D4ADAA04290E54@ecamlmw720.eamcs.ericsson.se> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00548.txt.bz2 On Wed, Jan 23, 2008 at 09:29:31AM -0500, Marc Khouzam wrote: > I hadn't thought of temporarily setting var->format, instead of passing 'format' > everywhere. Much easier! Is there any way that varob_get_value() could not return? > Like a failed gdb_assert? Or are we sure that var->format will be reset to > the old format properly no matter what happens to varobj_get_value? It may be possible - take a look at GDB's "cleanup" mechanism to handle this safely. -- Daniel Jacobowitz CodeSourcery