From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6248 invoked by alias); 23 Jan 2008 03:48:05 -0000 Received: (qmail 6240 invoked by uid 22791); 23 Jan 2008 03:48:04 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 23 Jan 2008 03:47:45 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 3FE5698375; Wed, 23 Jan 2008 03:47:43 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 1B48F98216; Wed, 23 Jan 2008 03:47:43 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JHWaT-0003aD-RX; Tue, 22 Jan 2008 22:47:41 -0500 Date: Wed, 23 Jan 2008 03:48:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH]: MI -var-set-format Message-ID: <20080123034741.GA13735@caradoc.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17494.64020.26176.277202@farnswood.snap.net.nz> <20060505181111.GI31029@nevyn.them.org> <17499.57333.952984.589237@farnswood.snap.net.nz> <20060515170640.GB385@nevyn.them.org> <17513.14914.566979.842465@farnswood.snap.net.nz> <20080122201234.GA20622@caradoc.them.org> <18326.45967.522349.613044@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18326.45967.522349.613044@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00539.txt.bz2 On Wed, Jan 23, 2008 at 04:25:03PM +1300, Nick Roberts wrote: > > Everyone seems to agree on this patch. It's OK to commit (IIRC you'll > > have to fix up another test too). The changes to mi-support.exp in > > the message I'm replying to do not look necessary. > > Without the change to mi-support.exp, I get: > > ERROR: can't read "octal": no such variable > > Do you mean that I should set in mi-var-display.exp or just use \[0-7\]+" > directly? That, or put the "set octal" line in gdb.exp (nothing mi-specific about it). I didn't see that line. All the changes to "global" lines are not needed. -- Daniel Jacobowitz CodeSourcery