From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26014 invoked by alias); 22 Jan 2008 19:30:25 -0000 Received: (qmail 25987 invoked by uid 22791); 22 Jan 2008 19:30:24 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 22 Jan 2008 19:29:07 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 4AF1898375; Tue, 22 Jan 2008 19:29:05 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id DBFBA98216; Tue, 22 Jan 2008 19:29:04 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JHOnv-0004hq-UV; Tue, 22 Jan 2008 14:29:03 -0500 Date: Tue, 22 Jan 2008 19:30:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Fix -break-insert -i. Message-ID: <20080122192903.GA18023@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200801222226.35445.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200801222226.35445.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00529.txt.bz2 On Tue, Jan 22, 2008 at 10:26:34PM +0300, Vladimir Prus wrote: > > It appears my breakpoint refactoring broke the -i parameter (ignore count) > for -break-insert. This patch fixes that, as well as adding a test for > that feature. OK? > > - Volodya > > gdb/ > * breakpoint.c (break_command_really): New parameter > ignore_count. > (break_command_1): Pass 0 as > ignore_count to break_command_really. > (gdb_breakpoint): Pass ignore_count to > break_command_really. > > gdb/testsuite > * gdb.mi/basics.c: Setup for testing breakpoints > ignore count. > * gdb.mi/mi-break.exp: Test for breakpoint ignore count. > * gdb.mi/mi-cli.exp: Adjust. > * gdb.mi/mi2-cli.exp: Adjust. OK. -- Daniel Jacobowitz CodeSourcery