From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9046 invoked by alias); 17 Jan 2008 14:47:10 -0000 Received: (qmail 9038 invoked by uid 22791); 17 Jan 2008 14:47:09 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 17 Jan 2008 14:46:47 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id m0HEkiIq211444 for ; Thu, 17 Jan 2008 14:46:44 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m0HEkii1741464 for ; Thu, 17 Jan 2008 15:46:44 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m0HEkiPK006057 for ; Thu, 17 Jan 2008 15:46:44 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m0HEkiUI006054; Thu, 17 Jan 2008 15:46:44 +0100 Message-Id: <200801171446.m0HEkiUI006054@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 17 Jan 2008 15:46:44 +0100 Subject: Re: [rfc] Remove default_gcore_mach from gcore.c To: deuling@de.ibm.com (Markus Deuling) Date: Thu, 17 Jan 2008 14:47:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <478F1CC5.904@de.ibm.com> from "Markus Deuling" at Jan 17, 2008 10:15:49 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00446.txt.bz2 Markus Deuling wrote: > bfd_set_format (obfd, bfd_core); > - bfd_set_arch_mach (obfd, default_gcore_arch (), default_gcore_mach ()); This doesn't look right -- you're removing the whole call, which means that not even the *arch* is now set in the generated core file ... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com