Re: [RFA] Handle BINOP_INTDIV in valarith.c

Joel Brobecker
2008-01-24T01:30:52Z

Pierre,

You raised some valid points in your message. I got a code review
for free :) and I sincerly thank you for that. I'll look into
them as soon as I can.

> OK, I get the idea, but the problem is that this leads to lots of code
> copy...

For this part, we can extract out the code you would otherwise
duplicate and have the pascal_evaluate_subexp call it.

> I agree with you that writing a pascal specific evaluate_subexp()
> function is better that explicitly checking the language of the
> currently parsed expression, but my idea was really to have on the
> contrary something usable for other languages, and thus not inside
> pascal specific code...

I don't think that we'll have to give up on your suggestion to
share the code. As explained above, any code that needs to be shared
can be shared through a single function. Would it work?

--
Joel