From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29886 invoked by alias); 15 Jan 2008 21:01:28 -0000 Received: (qmail 29875 invoked by uid 22791); 15 Jan 2008 21:01:27 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 15 Jan 2008 21:01:05 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id m0FL12Ad423928 for ; Tue, 15 Jan 2008 21:01:02 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m0FL127Y2273414 for ; Tue, 15 Jan 2008 22:01:02 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m0FL12sn012801 for ; Tue, 15 Jan 2008 22:01:02 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m0FL12x2012798; Tue, 15 Jan 2008 22:01:02 +0100 Message-Id: <200801152101.m0FL12x2012798@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 15 Jan 2008 22:01:02 +0100 Subject: Re: [patch] Remove BITS_BIG_ENDIAN from defs.h To: deuling@de.ibm.com (Markus Deuling) Date: Tue, 15 Jan 2008 21:01:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches), eliz@gnu.org (Eli Zaretskii), drow@false.org (Daniel Jacobowitz) In-Reply-To: <478C76F5.2000402@de.ibm.com> from "Markus Deuling" at Jan 15, 2008 10:03:49 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00368.txt.bz2 Markus Deuling wrote: > @@ -251,6 +252,7 @@ struct gdbarch startup_gdbarch = > /*per-architecture data-pointers and swap regions */ > 0, NULL, NULL, > /* Multi-arch values */ > + 0, /* bits_big_endian */ > 8 * sizeof (short), /* short_bit */ > 8 * sizeof (int), /* int_bit */ > 8 * sizeof (long), /* long_bit */ The "static default" of 0 for bits_big_endian is inconsistent with the static default of BFD_ENDIAN_BIG for byte_order ... > +# The bit byte-order has to do just with numbering of bits in debugging symbols > +# and such. Conceptually, it's quite separate from byte/word byte order. > +v:int:bits_big_endian:::0:(gdbarch->byte_order == BFD_ENDIAN_BIG)::0 ... so I guess this should preferably be: v:int:bits_big_endian:::1:(gdbarch->byte_order == BFD_ENDIAN_BIG)::0 Otherwise, this patch is OK, but please commit only together with ... >I tested this patch on both Little and Big Endian machine (x86/ppc) without regression. >If this patch is ok I'll post another one for the documentation. Ok to commit? ... the documentation patch (once that is approved). Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com