From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21372 invoked by alias); 15 Jan 2008 20:38:54 -0000 Received: (qmail 21364 invoked by uid 22791); 15 Jan 2008 20:38:54 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 15 Jan 2008 20:38:32 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id m0FKcUKa063138 for ; Tue, 15 Jan 2008 20:38:30 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m0FKcTa12863254 for ; Tue, 15 Jan 2008 21:38:29 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m0FKcTDt001280 for ; Tue, 15 Jan 2008 21:38:29 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m0FKcTYD001277; Tue, 15 Jan 2008 21:38:29 +0100 Message-Id: <200801152038.m0FKcTYD001277@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 15 Jan 2008 21:38:29 +0100 Subject: Re: [patch] Remove all current_gdbarch's in mn10300 To: deuling@de.ibm.com (Markus Deuling) Date: Tue, 15 Jan 2008 20:38:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <478C3F09.7090106@de.ibm.com> from "Markus Deuling" at Jan 15, 2008 06:05:13 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00361.txt.bz2 Markus Deuling wrote: > * mn10300-tdep.h (AM33_MODE): Add gdbarch as parameter. > * mn10300-tdep.c (set_reg_offsets, mn10300_analyze_prologue): Use > get_frame_arch to get at the current_architecture. Update AM33_MODE > call. > (mn10300_analyze_prologue): Add gdbarch as parameter. Update caller. > (mn10300_frame_unwind_cache): Use get_frame_arch to get at the current > architecture. > (set_reg_offsets, mn10300_analyze_prologue): Fix indentation. This is OK, but please fix this small whitespace issue: > + if (AM33_MODE (gdbarch)== 2) Space between ')' and '=='. > + if (AM33_MODE (gdbarch)== 2) Likewise. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com