From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9680 invoked by alias); 10 Jan 2008 04:16:08 -0000 Received: (qmail 9671 invoked by uid 22791); 10 Jan 2008 04:16:08 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 10 Jan 2008 04:15:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 21F642A9E6D; Wed, 9 Jan 2008 23:15:49 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id KsPWr3L9ANBt; Wed, 9 Jan 2008 23:15:49 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 491012A9E6C; Wed, 9 Jan 2008 23:15:48 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id D9F21E7ACB; Wed, 9 Jan 2008 20:15:40 -0800 (PST) Date: Thu, 10 Jan 2008 04:16:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: gdb-patches@sourceware.org Subject: Re: [RFC/RFA?] Should break FILE:LINENO skip prologue? Message-ID: <20080110041540.GK21281@adacore.com> References: <20080109151745.GA13181@adacore.com> <1199910284.14654.13.camel@localhost.localdomain> <20080109203453.GI21281@adacore.com> <1199912695.14654.21.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1199912695.14654.21.camel@localhost.localdomain> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00226.txt.bz2 > What about with a gui? The gui way of doing this > would be to click on the line with the opening curly-brace. Interestingly, the GUI is what started everything on our side. Average users using a GUI who wanted to break on a function simply clicked on the line where the function name was located, and expected things to just work. A question that I asked myself was: Why does "break FUNCTION_NAME" skip the prologue and yet "break FILE:LINENO" (from clicking on the filename) doesn't? > Sure, I appreciate that -- just speaking up for the other viewpoint. I understand. I am not denying that the other viewpoint will be negatively impacted, this is not what I was saying. Is the positive influence on the other side large enough that the change is worth it? The question is open. But I think that the fact that Apple made this change, and that AdaCore also proposed it independently of Apple, shows that the usage among users of both companies is more in favor of skipping the prologue. But if you think that the benefit is not large enough to warrant the change, then I think that's good feedback, and I'll introduce a switch and keep the current behavior as the default. I actually really believe that skipping the prologue is the most useful way of doing things, but I don't want to sound like I'm pushing hard for it. I'm happy if we have a switch - just sad that the other side of the camp doesn't see the light (yet :-P) :-). -- Joel