From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16024 invoked by alias); 10 Jan 2008 01:53:06 -0000 Received: (qmail 16015 invoked by uid 22791); 10 Jan 2008 01:53:06 -0000 X-Spam-Check-By: sourceware.org Received: from pool-96-233-71-153.bstnma.fios.verizon.net (HELO ednor.cgf.cx) (96.233.71.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 10 Jan 2008 01:52:45 +0000 Received: by ednor.cgf.cx (Postfix, from userid 201) id E701D2B352; Wed, 9 Jan 2008 20:52:43 -0500 (EST) Date: Thu, 10 Jan 2008 01:53:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org, Pierre Muller , Eli Zaretskii Subject: Re: [RFC] win32-nat.c: Improve handling of 'set shell on' Message-ID: <20080110015243.GA8464@ednor.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org, Pierre Muller , Eli Zaretskii References: <000001c8529e$a8088460$f8198d20$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00223.txt.bz2 On Wed, Jan 09, 2008 at 08:54:51PM +0200, Eli Zaretskii wrote: >> From: "Pierre Muller" >> Date: Wed, 9 Jan 2008 10:04:35 +0100 >> >> I recently discovered that if you use >> 'set shell on' on cygwin native, there are >> some specific problems that appear. >> >> I ran the testsuite with a single line >> modified: >> -static int useshell = 0; /* use shell for subprocesses */ >> +static int useshell = 1; /* use shell for subprocesses */ >> Which made the use of shell to start the subprocess >> the default. > >Is this really appropriate for the native Windows port of GDB as well >as for Cygwin? No. In fact, this really doesn't work all that well at all, AFAIK. The current code represents my initial attempt to get it working but there were problems which led me to believe that I needed to add some help in Cygwin itself. I think that the main reason for wanting to use the shell would be to interpret redirection and quoting characters and, last I checked, that was not right. That's why it defaults to false. cgf