Re: [RFC] win32-nat.c: Improve handling of 'set shell on'

Joel Brobecker
2008-01-09T20:04:02Z

> > I ran the testsuite with a single line
> > modified:
> > -static int useshell = 0; /* use shell for subprocesses */
> > +static int useshell = 1; /* use shell for subprocesses */
> > Which made the use of shell to start the subprocess
> > the default.
>
> Is this really appropriate for the native Windows port of GDB as well
> as for Cygwin? If not, we should set this only conditionally, I
> think.

I understood that this part of the patch was NOT to be committed
(from a // comment in the ChangeLog IIRC). After having explained
how the patch was tested, I would have excluded that hunk from
the patch, IMO.

--
Joel