From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix parameter coercing for Ada function calls (take 2)
Date: Tue, 08 Jan 2008 18:56:00 -0000 [thread overview]
Message-ID: <20080108185611.GA1375@caradoc.them.org> (raw)
In-Reply-To: <20080108185219.GF11650@adacore.com>
On Tue, Jan 08, 2008 at 10:52:19AM -0800, Joel Brobecker wrote:
> Hi Daniel,
>
> Does this look like what you had in mind? It's a little more work
> than my first patch, but indeed a little more elegant.
Yes, exactly.
> If PARAM_TYPE is non-NULL, it is the expected parameter type.
> IS_PROTOTYPED is non-zero if the function declaration is prototyped. */
Please add the new parameter to the comment.
> static struct value *
> value_arg_coerce (struct value *arg, struct type *param_type,
> - int is_prototyped)
> + int is_prototyped, CORE_ADDR *pc)
... and call it sp :-)
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-01-08 18:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 14:37 [RFA] Need post-processing of parameters for function calls in Ada Joel Brobecker
2008-01-08 15:02 ` Daniel Jacobowitz
2008-01-08 15:29 ` Joel Brobecker
2008-01-08 15:37 ` Daniel Jacobowitz
2008-01-08 15:50 ` Joel Brobecker
2008-01-08 15:57 ` Daniel Jacobowitz
2008-01-08 16:14 ` Joel Brobecker
2008-01-08 16:19 ` Daniel Jacobowitz
2008-01-08 18:53 ` [RFA] Fix parameter coercing for Ada function calls (take 2) Joel Brobecker
2008-01-08 18:56 ` Daniel Jacobowitz [this message]
2008-01-08 19:34 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108185611.GA1375@caradoc.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox