> Indentation is off here.
> 
> 	if (noside == EVAL_AVOID_SIDE_EFFECTS
> 	    && regno < (gdbarch_num_regs (current_gdbarch)
> 		        + gdbarch_num_pseudo_regs (current_gdbarch)))

Oops, you are right, of course. Thanks!
Fixed in the attached patch.

2008-01-04  Joel Brobecker  <brobecker@adacore.com>

        * eval.c (evaluate_subexp_standard): Add handling of user
        registers when in EVAL_AVOID_SIDE_EFFECTS mode.

2008-01-04  Joel Brobecker  <brobecker@adacore.com>

        * gdb.base/ptype.exp: Add testing of "ptype $pc".

-- 
Joel