Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Handle solaris dynamic linker name change.
Date: Fri, 04 Jan 2008 05:50:00 -0000	[thread overview]
Message-ID: <20080104054951.GB28411@adacore.com> (raw)
In-Reply-To: <200712242048.33983.vladimir@codesourcery.com>

Hi Volodya,

> The solutions are:
> 1. Stop gdb from thinking dynamic linker was unloaded
> 2. Revive re_enable_breakpoints_in_shlibs
> 3. Make breakpoint_re_set one try to re-enable bp_shlib_event
> 
> I think (1) is best, since it will make (2) or (3) unnecessary.

I agree.

> 	Ignore change in name of dynamic linker during
> 	execution.  This also unbreaks pending breakpoints.
> 	* solist.h (struct target_so_ops): New field
> 	same.
> 	* solib-svr4.c (svr4_same): New.
> 	(_initialize_svr4_solib): Register svr4_same.
> 	* solib.c (update_solib_list): Use ops->same,
> 	if available.

I really liked the idea of the patch, but I think your change
will affect more than just solaris. the solib-svr4 target_so_ops
is used by many targets, not just solaris ones.

Within the same idea, how about making this a gdbarch method/function?
The default value would be a function that does a *filename_cmp*
(first improvement introduced by your patch ;-), and on solaris,
we would provide a function that first does a filename_cmp, and
if that fails, then looks at the specific name.

I'd like the feedback from other maintainers about this.

Thanks,
-- 
Joel


  parent reply	other threads:[~2008-01-04  5:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-26  6:00 Vladimir Prus
2007-12-27 18:18 ` Doug Evans
2007-12-27 18:37   ` Vladimir Prus
2008-01-04  5:50 ` Joel Brobecker [this message]
2008-01-04 12:46   ` Daniel Jacobowitz
2008-01-04 15:30     ` Joel Brobecker
2008-01-07 15:24       ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080104054951.GB28411@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox