From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6130 invoked by alias); 3 Jan 2008 04:30:33 -0000 Received: (qmail 6122 invoked by uid 22791); 3 Jan 2008 04:30:31 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 03 Jan 2008 04:29:58 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 06B992A9636 for ; Wed, 2 Jan 2008 23:29:57 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id g7-1I6Wl5qKh for ; Wed, 2 Jan 2008 23:29:56 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3E5882A9635 for ; Wed, 2 Jan 2008 23:29:56 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 04800E7ACB; Wed, 2 Jan 2008 20:29:48 -0800 (PST) Date: Thu, 03 Jan 2008 04:30:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: [RFA] Fix "set lang auto" oddity when inferior not started yet Message-ID: <20080103042948.GG15903@adacore.com> References: <20080102133132.GD15903@adacore.com> <20080102135623.GA13737@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080102135623.GA13737@caradoc.them.org> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00031.txt.bz2 > > 2008-01-02 Joel Brobecker > > > > * symfile.c (set_initial_language): Make non-static. > > * symfile.h (set_initial_language): Add declaration. > > * language.c: #include "symfile.h". > > (set_language): Call set_initial_language if the frame language > > could not be determined. > > > > I also wrote a tiny testcase: > > > > 2008-01-02 Joel Brobecker > > > > * gdb.base/set_lang_auto.exp: New testcase. > > Looks fine. Dashes outnumber underscores (300 to 80) in the > testsuite, so please use those instead. Great, thanks! I changed the underscores into dashes, and checked everything in. BTW: When I ran the debugger against our testsuite, I started with slightly less than 200 failures. With all the patches I submitted, I'm now down to 38. If I don't get distracted, we could have something very very good soon! -- Joel