From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17727 invoked by alias); 2 Jan 2008 14:01:58 -0000 Received: (qmail 17674 invoked by uid 22791); 2 Jan 2008 14:01:56 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 02 Jan 2008 13:56:39 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 752CA9811F; Wed, 2 Jan 2008 13:56:24 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 613B898118; Wed, 2 Jan 2008 13:56:24 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JA451-0002hg-C2; Wed, 02 Jan 2008 08:56:23 -0500 Date: Wed, 02 Jan 2008 14:01:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Fix "set lang auto" oddity when inferior not started yet Message-ID: <20080102135623.GA13737@caradoc.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org References: <20080102133132.GD15903@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080102133132.GD15903@adacore.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00022.txt.bz2 On Wed, Jan 02, 2008 at 05:31:32AM -0800, Joel Brobecker wrote: > The attached patch fixes the problem. > > 2008-01-02 Joel Brobecker > > * symfile.c (set_initial_language): Make non-static. > * symfile.h (set_initial_language): Add declaration. > * language.c: #include "symfile.h". > (set_language): Call set_initial_language if the frame language > could not be determined. > > I also wrote a tiny testcase: > > 2008-01-02 Joel Brobecker > > * gdb.base/set_lang_auto.exp: New testcase. Looks fine. Dashes outnumber underscores (300 to 80) in the testsuite, so please use those instead. -- Daniel Jacobowitz CodeSourcery