Re: [RFA] new set/show multiple-choice-auto-select commands

Joel Brobecker
2008-01-15T12:37:30Z

Hi Markus,

> I attached a patch which introduces a new command "set symbol-user-choice
> on" which is off per default. If set to on a symbol lookup finding
> >1 appropriate symbol (for example break foo, with foo in main and in a
> >shared lib) a user choice (decode_line_2) is invoked.

The principle is indeed the same. The semantics of your command
are a little unclear to me, as you didn't say what should happen
if symbol-user-choice is off and you have more than one symbol matching.
Do you cancel the lookup, choose all symbols, and pick one at random?

We have one non-technical issue to solve if we are to merge the two
ideas into one setting: You suggest the default to be off, which means
no menu. But in Ada, we want the default to be "on" because we have
always printed these menus in Ada, and removing them now would be
a change of behavior.

> Maybe we can merge the patches? I'd like to see the "set
> symbol-user-choice on|off" command rather in a language-undependent
> place like linespec.c as in a language-specific file like ada. What do
> you think? Do you see the possibility for that?

Absolutely. The reason why I posted this patch as a RFC is that
I realized that this feature could be used for all languages,
not just Ada. It's still on my plate to adjust the patch to put
this in linespec instead of ada-lang - I will get to it soon.

Would you be ok with using my command, however? I like the name better,
but most of all, it's a little more complete: It's a tri-state setting
as opposed to a binary one. We need to resolve the issue of the default.

> Btw, I'd really appreciate your feedback on that patch. Would this be ok
> for mainline?

I'll admit that I only quickly scanned the patch, because I actually
prefer the command that I suggested...

--
Joel